[ISSUE #402] Add proxy fallback for request codes 106/206 not supported#417
Closed
itxaiohanglover wants to merge 1 commit into
Closed
[ISSUE #402] Add proxy fallback for request codes 106/206 not supported#417itxaiohanglover wants to merge 1 commit into
itxaiohanglover wants to merge 1 commit into
Conversation
…upported When RocketMQ Dashboard connects to RocketMQ 5.4.0+ in proxy mode, certain request codes (106 GET_BROKER_CLUSTER_INFO, 206 GET_ALL_TOPIC_LIST_FROM_NAMESERVER) are not supported by the broker. Add getBrokerClusterInfo and getAllTopicListFromNameServer methods to ProxyAdmin/ProxyAdminImpl that send requests to the proxy address. Update ClusterServiceImpl, ClusterInfoService, and TopicServiceImpl to fall back to the proxy when the standard mqAdminExt methods fail.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #402. When dashboard connects to RocketMQ 5.4.0+ in proxy mode, request codes 106 (GET_BROKER_CLUSTER_INFO) and 206 (GET_ALL_TOPIC_LIST_FROM_NAMESERVER) are not supported by the broker. Added proxy fallback in ClusterServiceImpl, ClusterInfoService, and TopicServiceImpl.