Skip to content

[ISSUE #411] Fix NPE when getAllSubscriptionGroup returns null #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itxaiohanglover wants to merge 1 commit into from
Closed

[ISSUE #411] Fix NPE when getAllSubscriptionGroup returns null #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/org/apache/rocketmq/dashboard/service/impl/ConsumerServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,10 @@ public void makeGroupListCache(String address) {
ClusterInfo clusterInfo = clusterInfoService.get();
for (BrokerData brokerData : clusterInfo.getBrokerAddrTable().values()) {
subscriptionGroupWrapper = mqAdminExt.getAllSubscriptionGroup(brokerData.selectBrokerAddr(), 30000L);
if (subscriptionGroupWrapper == null) {
logger.warn("getAllSubscriptionGroup returned null for broker: {}", brokerData.selectBrokerAddr());
continue;
}
for (String groupName : subscriptionGroupWrapper.getSubscriptionGroupTable().keySet()) {
if (!consumerGroupMap.containsKey(groupName)) {
consumerGroupMap.putIfAbsent(groupName, new ArrayList<>());
Expand All @@ -194,7 +198,7 @@ public void makeGroupListCache(String address) {
throw new RuntimeException(err);
}

if (subscriptionGroupWrapper != null && subscriptionGroupWrapper.getSubscriptionGroupTable().isEmpty()) {
if (subscriptionGroupWrapper == null || subscriptionGroupWrapper.getSubscriptionGroupTable().isEmpty()) {
logger.warn("No subscription group information available");
isCacheBeingBuilt = false;
return;
Expand Down