[ISSUE #411] Fix NPE when getAllSubscriptionGroup returns null#412
Closed
itxaiohanglover wants to merge 1 commit into
Closed
[ISSUE #411] Fix NPE when getAllSubscriptionGroup returns null#412itxaiohanglover wants to merge 1 commit into
itxaiohanglover wants to merge 1 commit into
Conversation
When mqAdminExt.getAllSubscriptionGroup() returns null (e.g. broker not reachable or ACL denied), the code calls subscriptionGroupWrapper.getSubscriptionGroupTable() which throws NPE. Add null check after getAllSubscriptionGroup call, skip to next broker if null. Also fix post-loop check to handle null (empty broker table).
|
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #411
Brief Description
When
mqAdminExt.getAllSubscriptionGroup()returnsnull(e.g. broker not reachable, ACL denied, or 5.x Proxy mode where the call is not supported), the code at line 183 callssubscriptionGroupWrapper.getSubscriptionGroupTable()which throws:Root cause: No null check on the return value of
getAllSubscriptionGroup()before accessing its methods.Fix:
getAllSubscriptionGroupreturns null, log a warning and skip to the next broker instead of crashing.subscriptionGroupWrapper != null && ...isEmpty()would fall through to line 202 and NPE ifsubscriptionGroupWrapperwas null (e.g. empty broker table). Changed tosubscriptionGroupWrapper == null || ...isEmpty()to handle both cases.How Did You Test This Change?
Manual code review against the issue stack trace. The fix follows the same null-guard pattern already used elsewhere in the codebase (e.g.
examineSubscriptionGroupConfigfallback at line 218).