HBASE-30033 Scan.setFilter() should validate against existing batch setting#7988
Open
mini666 wants to merge 4 commits intoapache:masterfrom
Open
HBASE-30033 Scan.setFilter() should validate against existing batch setting#7988mini666 wants to merge 4 commits intoapache:masterfrom
mini666 wants to merge 4 commits intoapache:masterfrom
Conversation
Member
|
Hi, @mini666, please rebase master and retry? Thanks! |
…etting Scan.setBatch() validates that the scan does not have a filter with hasFilterRow()=true. However, Scan.setFilter() does not perform the reverse check. This allows creating an invalid Scan by calling setBatch() before setFilter(), bypassing the validation that setBatch() was designed to enforce. Added validation in setFilter() to throw IncompatibleFilterException when a filter with hasFilterRow()=true is set on a scan that already has batch configured.
- testSetFilterWithBatchThrows: setBatch() then setFilter(PageFilter) should throw IncompatibleFilterException - testSetFilterWithoutBatchDoesNotThrow: setFilter(PageFilter) without batch should succeed - testSetFilterWithBatchAndNonFilterRowFilter: setBatch() then setFilter(FilterList) should succeed since FilterList.hasFilterRow() returns false
vaijosh
approved these changes
Mar 27, 2026
liuxiaocs7
reviewed
Mar 27, 2026
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestScan.java
Outdated
Show resolved
Hide resolved
Contributor
|
We have already migrated to junit5 so we can not use expected any more. Please use assertThrows instead. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scan.setBatch()validates that the scan does not have a filter withhasFilterRow()=true, throwingIncompatibleFilterExceptionif it does. However,Scan.setFilter()does not perform the reverse check against an existing batch setting.This allows creating an invalid Scan by calling
setBatch()beforesetFilter(), bypassing the validation:Fix
Added validation in Scan.setFilter() to throw IncompatibleFilterException when a filter with hasFilterRow()=true is set on a scan that already has batch configured.
Jira
https://issues.apache.org/jira/browse/HBASE-30033