Skip to content

Commit a49a095

Browse files
mini666juke-mini666
authored andcommitted
HBASE-30033 Add tests for setFilter() batch validation
- testSetFilterWithBatchThrows: setBatch() then setFilter(PageFilter) should throw IncompatibleFilterException - testSetFilterWithoutBatchDoesNotThrow: setFilter(PageFilter) without batch should succeed - testSetFilterWithBatchAndNonFilterRowFilter: setBatch() then setFilter(FilterList) should succeed since FilterList.hasFilterRow() returns false
1 parent 853f630 commit a49a095

File tree

1 file changed

+24
-0
lines changed
  • hbase-client/src/test/java/org/apache/hadoop/hbase/client

1 file changed

+24
-0
lines changed

hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestScan.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
import org.apache.hadoop.hbase.HConstants;
3030
import org.apache.hadoop.hbase.client.Scan.ReadType;
3131
import org.apache.hadoop.hbase.filter.FilterList;
32+
import org.apache.hadoop.hbase.filter.IncompatibleFilterException;
33+
import org.apache.hadoop.hbase.filter.PageFilter;
3234
import org.apache.hadoop.hbase.security.access.Permission;
3335
import org.apache.hadoop.hbase.security.visibility.Authorizations;
3436
import org.apache.hadoop.hbase.testclassification.ClientTests;
@@ -254,6 +256,28 @@ public void testScanCopyConstructor() throws Exception {
254256
"Make sure copy constructor adds all the fields in the copied object");
255257
}
256258

259+
@Test(expected = IncompatibleFilterException.class)
260+
public void testSetFilterWithBatchThrows() {
261+
Scan scan = new Scan();
262+
scan.setBatch(5);
263+
scan.setFilter(new PageFilter(10));
264+
}
265+
266+
@Test
267+
public void testSetFilterWithoutBatchDoesNotThrow() {
268+
Scan scan = new Scan();
269+
scan.setFilter(new PageFilter(10));
270+
// no exception expected
271+
}
272+
273+
@Test
274+
public void testSetFilterWithBatchAndNonFilterRowFilter() {
275+
Scan scan = new Scan();
276+
scan.setBatch(5);
277+
scan.setFilter(new FilterList());
278+
// FilterList.hasFilterRow() returns false, so no exception expected
279+
}
280+
257281
@Test
258282
public void testScanReadType() throws Exception {
259283
Scan scan = new Scan();

0 commit comments

Comments
 (0)