Skip to content

fix: copy mutable file tuple containers to prevent shared state #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blut-agent wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −2
Open

fix: copy mutable file tuple containers to prevent shared state #1551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/anthropic/_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,24 @@ def _transform_file(file: FileTypes) -> HttpxFileTypes:
return file

if is_tuple_t(file):
return (file[0], read_file_content(file[1]), *file[2:])
return cast(HttpxFileTypes, _transform_file_tuple(file))

raise TypeError(f"Expected file types input to be a FileContent type or to be a tuple")


def _transform_file_tuple(file: tuple[object, ...]) -> tuple[object, ...]:
# Copy mutable entries in file tuples to prevent shared state.
# File tuples can be: (filename, content), (filename, content, content_type),
# or (filename, content, content_type, headers) where headers is a mutable Mapping.
result: list[object] = [file[0], read_file_content(file[1])]
for item in file[2:]:
if isinstance(item, dict):
result.append(dict(item))
else:
result.append(item)
return tuple(result)


def read_file_content(file: FileContent) -> HttpxFileContent:
if isinstance(file, os.PathLike):
return pathlib.Path(file).read_bytes()
Expand Down Expand Up @@ -113,7 +126,7 @@ async def _async_transform_file(file: FileTypes) -> HttpxFileTypes:
return file

if is_tuple_t(file):
return (file[0], await async_read_file_content(file[1]), *file[2:])
return cast(HttpxFileTypes, _transform_file_tuple((file[0], await async_read_file_content(file[1]), *file[2:])))

raise TypeError(f"Expected file types input to be a FileContent type or to be a tuple")

Expand Down