fix: copy mutable file tuple containers to prevent shared state#1551
Open
blut-agent wants to merge 1 commit into
Open
fix: copy mutable file tuple containers to prevent shared state#1551blut-agent wants to merge 1 commit into
blut-agent wants to merge 1 commit into
Conversation
File upload helpers were sharing mutable containers nested inside file tuples, such as per-file headers dictionaries. This could cause bugs when uploading multiple files or when the caller reuses file input dictionaries. - Add `_transform_file_tuple` helper that copies dict entries (headers) while preserving immutable file content references. - Use the helper in both `_transform_file` and `_async_transform_file`. - Add regression test for file tuple with mutable headers. Fixes anthropics#1548
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent file upload helpers from sharing mutable containers nested inside file tuples, such as per-file headers dictionaries.
Changes
_transform_file_tuplehelper that copies dict entries (headers) while preserving immutable file content references._transform_fileand_async_transform_file.Testing
python -m pytest tests/test_files.py -qFixes #1548