Skip to content

[MWPW-193582] - Optimize global navigation sticky detection and animation layers #5897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DKos95 wants to merge 2 commits into
base: stage
Choose a base branch
from
Open

[MWPW-193582] - Optimize global navigation sticky detection and animation layers #5897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc1f44e
perf: optimize global navigation sticky detection and animation layers
DKos95 Apr 29, 2026
d0774e8
update test globalnav
DKos95 May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libs/blocks/global-navigation/global-navigation.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,6 +912,7 @@ header.new-nav .feds-nav-wrapper--expanded .feds-nav > section.feds-navItem > bu
animation: slideleft 0.4s ease, fadein 0.2s ease;
animation-fill-mode: forwards;
padding: 15px 20px;
will-change: translate, opacity;
}

[dir = "rtl"] header.new-nav .feds-nav-wrapper--expanded .feds-nav > section.feds-navItem > button.feds-navLink {
Expand All @@ -925,6 +926,7 @@ header.new-nav .feds-nav > section.feds-navItem > button.feds-navLink {
border: none;
animation: slideright 0.4s ease, fadeout 0.2s ease;
animation-fill-mode: forwards;
will-change: translate, opacity;
}

[dir = "rtl"] header.new-nav .feds-nav > section.feds-navItem > button.feds-navLink {
Expand Down
38 changes: 16 additions & 22 deletions libs/blocks/global-navigation/global-navigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,30 +745,24 @@ class Gnav {
if (promo) localNav.classList.add('has-promo');
this.elements.localNav = localNav;
firstElem.textContent = title.trim();
const isAtTop = () => {
const rect = this.elements.localNav.getBoundingClientRect();
// note: ios safari changes between -0.34375, 0, and 0.328125
return rect.top === 0;
};
const stickyObserver = new IntersectionObserver(
([entry]) => {
this.elements.localNav?.classList.toggle('is-sticky', entry.boundingClientRect.top <= 0);
},
{ threshold: [1] },
);
stickyObserver.observe(this.elements.localNav);
window.addEventListener('scroll', (e) => {
const classList = this.elements.localNav?.classList;
if (classList.contains('feds-localnav--active')) {
trigger({
element: curtain,
event: e,
type: 'localNav-curtain',
animatedElement: itemWrapper,
animationType: 'transition',
});
}
if (isAtTop()) {
if (!classList?.contains('is-sticky')) {
classList?.add('is-sticky');
}
} else {
classList?.remove('is-sticky');
}
});
if (!classList?.contains('feds-localnav--active')) return;
trigger({
element: curtain,
event: e,
type: 'localNav-curtain',
animatedElement: itemWrapper,
animationType: 'transition',
});
}, { passive: true });
};

decorateTopnavWrapper = async () => {
Expand Down
22 changes: 14 additions & 8 deletions test/blocks/global-navigation/global-navigation.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,21 +810,27 @@ describe('global navigation', () => {
});

it('should remove is-sticky class to localnav on scroll less than localnav placement', async () => {
let stickyCallback;
const OrigIO = window.IntersectionObserver;
window.IntersectionObserver = function IOmock(cb) { stickyCallback = cb; };
window.IntersectionObserver.prototype = { observe() {}, disconnect() {} };
await createFullGlobalNavigation({ globalNavigation: gnavWithlocalNav });
stickyCallback([{ boundingClientRect: { top: 20 } }]);
window.IntersectionObserver = OrigIO;
const localNav = document.querySelector(selectors.localNav);
sinon.stub(localNav, 'getBoundingClientRect').returns({ top: 20 });
window.dispatchEvent(new Event('scroll'));
const localNavAfterScroll = document.querySelector(selectors.localNav);
expect(localNavAfterScroll.classList.contains('is-sticky')).to.be.false;
expect(localNav.classList.contains('is-sticky')).to.be.false;
});

it('should add is-sticky class to localnav on scroll greater than localnav placement', async () => {
let stickyCallback;
const OrigIO = window.IntersectionObserver;
window.IntersectionObserver = function IOmock(cb) { stickyCallback = cb; };
window.IntersectionObserver.prototype = { observe() {}, disconnect() {} };
await createFullGlobalNavigation({ globalNavigation: gnavWithlocalNav });
stickyCallback([{ boundingClientRect: { top: 0 } }]);
window.IntersectionObserver = OrigIO;
const localNav = document.querySelector(selectors.localNav);
sinon.stub(localNav, 'getBoundingClientRect').returns({ top: 0 });
window.dispatchEvent(new Event('scroll'));
const localNavAfterScroll = document.querySelector(selectors.localNav);
expect(localNavAfterScroll.classList.contains('is-sticky')).to.be.true;
expect(localNav.classList.contains('is-sticky')).to.be.true;
});

it('should open both screen if localnav is present but shows only level 2 screen', async () => {
Expand Down
Loading