[MWPW-193582] - Optimize global navigation sticky detection and animation layers#5897
Open
[MWPW-193582] - Optimize global navigation sticky detection and animation layers#5897
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
SilviuLCF
approved these changes
May 6, 2026
SilviuLCF
left a comment
SilviuLCF
left a comment
There was a problem hiding this comment.
Performance testing PASS - https://jira.corp.adobe.com/browse/MWPW-193582
Contributor
sharmrj
approved these changes
May 6, 2026
Contributor
Author
My mistake, it should still be a nice improvement though for c1, wether your team has the bandwidth to test this thoroughly is another thing. |
adeshmukh-1585
approved these changes
May 6, 2026
sonawanesnehal3
approved these changes
May 6, 2026
Contributor
|
Reminder to set the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the getBoundingClientRect() check in the scroll handler for local nav sticky state with an IntersectionObserver at threshold: 1, removing the layout-triggering rect read from the scroll hot path entirely. The scroll listener is now also marked { passive: true }. Also adds will-change: translate, opacity to the nav link slide/fade animations so the browser promotes those elements to the compositor upfront.
Resolves: MWPW-193582
PSI Test URLs:
Before: https://main--milo--adobecom.aem.page/?martech=off
After: https://perf-global-navigation-optimizations--milo--adobecom.aem.page/?martech=off
Test URLs:
Before: https://load-c2-styles--upp--adobecom.aem.live/homepage/drafts/ramuntea/redesign-demo?milolibs=site-redesign-foundation
After: https://load-c2-styles--upp--adobecom.aem.live/homepage/drafts/ramuntea/redesign-demo?milolibs=perf-global-navigation-optimizations
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale