Remove unnecessary IF function - #181
Open
Wegerich wants to merge 7 commits into
Open
Conversation
Corrected grammatical errors, fixed broken links, and added a Syntax Highlighting option for VSCode.
Updated link
Updated for iCue 5.7 The previous version broke terribly. It did not allow you to edit anything on the assignments page. NOTHING was selectable except the top entry (template). I rebuilt the profile for the new version by importing every key from the old profile by hand, and it now works properly for iCue 5.7. Further, there's an odd bug where sometimes if you reassign a key, another will become unassigned. Don't ask me why, I have no idea. I think It's an iCue bug rather than a profile bug. So, simply go ahead and reassign it after that happens and it should stick.
Update readme.md
Update K55_wrapped_in_F24.cueprofile
Update README.md
The IF function that was previously here is unnecessary because LUA already checks whether a device is already matching the specified name when `lmc_assign_keyboard('name');` is run. If the device is assigned then it will not ask for manual assignment.
Owner
|
Thanks, but I'm not gonna change it. The code, as it exists now, works,
from the last time I used it many years ago. I'm not gonna re-load and
re-test everything for a minor potential optimization. This is on github
mostly for people to copy it, not to contribute. I don't know how to turn
off contributions and I don't care to look, either...
…On Mon, Jan 13, 2025 at 7:36 AM Wegerich ***@***.***> wrote:
The IF function that was previously here is unnecessary because LUA
already checks whether a device is already matching the specified name when
lmc_assign_keyboard('name'); is run. If the device is assigned then it
will not ask for manual assignment.
------------------------------
You can view, comment on, or merge this pull request online at:
#181
Commit Summary
- bf187a9
<bf187a9>
Remove unnecessary IF function
File Changes
(1 file <https://github.com/TaranVH/2nd-keyboard/pull/181/files>)
- *M* LUAMACROS/SECOND_KEYBOARD_script_for_LUA_MACROS.lua
<https://github.com/TaranVH/2nd-keyboard/pull/181/files#diff-82a3cc78893dae946286268c3f4c590ca23fc96fab93dba57b700472f79ace87>
(5)
Patch Links:
- https://github.com/TaranVH/2nd-keyboard/pull/181.patch
- https://github.com/TaranVH/2nd-keyboard/pull/181.diff
—
Reply to this email directly, view it on GitHub
<#181>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD2MGX4OS5SVJTNHFF7KGSL2KPMOXAVCNFSM6AAAAABVC4GABOVHI2DSMVQWIX3LMV43ASLTON2WKOZSG44DIMZWGU4TCNQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Contributor
Author
|
That's totally fair enough. I appreciate you going to the trouble of making it available. I still use it all these years later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IF function that was previously here is unnecessary because LUA already checks whether a device is already matching the specified name when
lmc_assign_keyboard('name');is run. If the device is assigned then it will not ask for manual assignment.