Remove unnecessary IF function - #67
Closed
Wegerich wants to merge 1 commit into
Closed
Conversation
The IF function that was previously here is unnecessary because LUA already checks whether a device is already matching the specified name when `lmc_assign_keyboard('name');` is run. If the device is assigned then it will not ask for manual assignment.
|
there's conflict in your branch, probably due to a change you made to the IF. |
Wegerich
marked this pull request as draft
January 13, 2025 15:28
Contributor
Author
|
Thanks for the heads up. Looks like I was running an old version of the repository when I made the pull request. I'm not very familiar with github so please forgive my mistake. I made a new pull request here by directly editing the existing code: #181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IF function that was previously here is unnecessary because LUA already checks whether a device is already matching the specified name when
lmc_assign_keyboard('name');is run. If the device is assigned then it will not ask for manual assignment.