📽 Add Viking Movie to streaming media#3613
Conversation
Co-authored-by: Hawken Rives <hawkrives@gmail.com>
|
So glad to finally have this PR'd! Thanks for the work on getting it back onto master, Drew! |
This PR modified important files but does not have any changes to the CHANGELOG.
New dependencies added: polishedAuthor: Brian Hough Description: A lightweight toolset for writing styles in Javascript. Homepage: https://polished.js.org/
|
| Created | about 5 years ago |
| Last Updated | 9 days ago |
| License | ISC |
| Maintainers | 2 |
| Releases | 71 |
| Direct Dependencies | prop-types |
| Keywords | react, async, promise, fetch and hook |
Big PR! We like to try and keep PRs under 400 lines, and this one was 1525 lines.
* horizontal scrolling to genres * move year year and runtime above genres * tighten up vertical spacing between sections
|
This looks awesome! |
|
I've just checked off
because I've just updated the sga-weekly-movies script to generate an "upcoming.json" file, which looks like this: [
{
"movie": "https://stodevx.github.io/sga-weekly-movies/movies/2019-05-03%20Up/index.json",
"first_showing": "2019-05-03",
"last_showing": "2019-05-03"
},
{
"movie": "https://stodevx.github.io/sga-weekly-movies/movies/2019-05-04%20Ratatouille/index.json",
"first_showing": "2019-05-04",
"last_showing": "2019-05-04"
},
{
"movie": "https://stodevx.github.io/sga-weekly-movies/movies/2019-05-10%20The%20Lego%20Movie%202%3A%20The%20Second%20Part/index.json",
"first_showing": "2019-05-10",
"last_showing": "2019-05-11"
},
{
"movie": "https://stodevx.github.io/sga-weekly-movies/movies/2019-05-18%20High%20School%20Musical%202/index.json",
"first_showing": "2019-05-17",
"last_showing": "2019-05-18"
},
{
"movie": "https://stodevx.github.io/sga-weekly-movies/movies/2019-05-19%20High%20School%20Musical%203%3A%20Senior%20Year/index.json",
"first_showing": "2019-05-19",
"last_showing": "2019-05-20"
}
]Or, if there are no upcoming movies, like this: []We can probably replace the lookup of |
|
Anyone care if I merge master into this branch to refresh CI checks? Also, is there anything outstanding that I can work on? |
|
I’d love it if you could merge master into here. Hawken’s comment above needs some fleshing out but I like the sound of his logic. |
Manual conflict resolution done by taking the latest versions from the `master` branch and only leaving HEAD versions when they were not otherwise installed on `master`. `yarn` concurs and auto-merged these changesets. Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com> Tested-by: Kristofer Rye <kristofer.rye@gmail.com>
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Closes #2573
I'm very excited to present a very long running feature that @hawkrives and myself have worked on-and-off on for quite some time. It is a beautiful view both aesthetically and in its use of small, reusable components. @hawkrives even added some react hooks!
We aim to present the week's movies that will be showing in Viking Theater. The information we present contains:
📸 Screenshots
We have a laundry list of things we still want to get done