Update react-theme-provider to v2#3614
Closed
hawkrives wants to merge 12 commits into
Closed
Conversation
…rovider-2.x' into theme-update * origin/renovate/callstack-react-theme-provider-2.x: Update dependency @callstack/react-theme-provider to v2
* master: (98 commits) Update dependency react-native-device-info to v1.4.1 Update dependency react-native-device-info to v1.3.0 Update dependency react-native-device-info to v1.2.0 (Maybe) fix sentry sourcemaps Update dependency gradle to v5.3.1 Update dependency danger to v7.0.17 Update dependency detox to v12 Update dependency semver to v6 navigation-buttons: Migrate to platformPrefixIconName Update dependency react-native-paper to v2.15.0 Update dependency react-native to v0.59.2 remove *:release package.json scripts dedupe yarn.lock Update yarn.lock update circle's Xcode to 10.2 open skate and open hockey hours Rename a few gym hours to insert ice arena hours Update dependency danger to v7.0.16 Update dependency react-native-vector-icons to v6.4.2 Update dependency react-native-device-info to v1.1.0 ... # Conflicts: # modules/toolbar/toolbar-button.js # source/views/streaming/radio/buttons.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3549
Converts us from ThemeProvider and the
withThemehigher-order component (HOC) to ThemeProvider and typed(!)useThemehook.Old
New
and useTheme automatically(*) knows the shape of our theme.
*: it's defined in
@frogpond/themeNOTE: I don't think I've tried running this locally, but it was blocked on react-theme-provider@2.0.1, which just came out, so I wanted to get this out.
This also has an alternate version of
useViewportfrom #3613; I will resolve the conflict with whichever one goes in first. They're roughly equivalent.