[modularization] Re-export react-native-tableview-simple and put our custom cells into a module#2895
Merged
Conversation
rye
approved these changes
Aug 26, 2018
drewvolz
previously approved these changes
Aug 26, 2018
rye
previously approved these changes
Aug 26, 2018
rye
force-pushed
the
reorg-take6-part5.12
branch
from
6b37561 to
a18d3b4
Compare
Member
|
This could use a sanity check post-rebase. I had a merge conflict. |
Member
Author
|
Except for the fact that it needs more commits |
Member
|
Okay, I'll just merge the appropriate branch, then. |
rye
force-pushed
the
reorg-take6-part5.12
branch
from
1eccc57 to
296962d
Compare
rye
approved these changes
Aug 27, 2018
rye
left a comment
rye
left a comment
Member
There was a problem hiding this comment.
Flow passes locally, and this PR is now atomic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things:
@frogpond/tableview.react-native-tableview-simpleI'm aiming to get to where we can design with TableView and style appropriately for Android/iOS, and I think that
@frogpond/tableviewis where we should expose that to our app.Also, it'll let us have one place to set defaults for the app, like setting the Section's background color.
Neither of those things have yet been implemented.
Part of the great #1537 redo.