[modularization] Move FilterView to a new module#2896
Merged
Conversation
rye
previously approved these changes
Aug 26, 2018
drewvolz
previously approved these changes
Aug 26, 2018
rye
force-pushed
the
reorg-take6-part5.13
branch
from
c4bb9ce to
e1e28fe
Compare
Member
|
This PR could use a sanity check post-rebase. |
Member
Author
|
So if this doesn't include the commits from #2893, how can https://github.com/StoDevX/AAO-React-Native/pull/2896/files#diff-40d4f57836a110fe35c2488ee1c1a70bR17 work? |
Member
Author
|
Needs #2893 |
Member
rye
force-pushed
the
reorg-take6-part5.13
branch
from
9a1aa63 to
f647a07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the "filter" components into a module,
@frogpond/filter.Part of the great #1537 redo.
Closes #2895. (because it includes it)