Skip to content

fix: replace panic("unreachable") with descriptive error in SSE handler #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
changkun merged 1 commit into from
Apr 10, 2026
Merged

fix: replace panic("unreachable") with descriptive error in SSE handler #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion parse_get.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,16 @@ func (c *Client) handleSSEResponse(req *http.Request, onUpdate ParseResultUpdate
return &result, nil
}

var lastEvent string
var eventCount int
for ev, err := range sse.ScanEvents(resp.Body) {
if err != nil {
return nil, fmt.Errorf("failed to scan SSE events: %w", err)
}

lastEvent = ev.Name()
eventCount++

// Unmarshal the event data into a ParseResult.
var result ParseResult
if err := json.Unmarshal(ev.Data(), &result); err != nil {
Expand Down Expand Up @@ -182,5 +187,8 @@ func (c *Client) handleSSEResponse(req *http.Request, onUpdate ParseResultUpdate
}
}

panic("unreachable")
if eventCount == 0 {
return nil, fmt.Errorf("SSE stream closed without sending any events")
}
return nil, fmt.Errorf("SSE stream ended after %d event(s), last event %q, without a terminal event (parse_done or parse_failed)", eventCount, lastEvent)
}
Loading