fix: replace panic("unreachable") with descriptive error in SSE handler#21
Merged
Conversation
The SSE event loop in handleSSEResponse could exit without hitting a
terminal event (parse_done or parse_failed) when the server disconnects
prematurely. This was guarded by panic("unreachable") which crashed the
caller. Return a descriptive error instead, reporting whether zero or
partial events were received and the last event name seen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
panic("unreachable")at the end ofhandleSSEResponsewith a proper error returnparse_done/parse_failed) when the server disconnects prematurely — this was causing a crash in callers