fix: avoid duplicate brewing scanning boon - #40
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
A turtle with the
turtlematic:starbound_brewing_automataupgrade crashes the dedicated server while its block entity initializes.Root Cause
ExperienceAutomataCorePeripheralinvokes the virtualattachScanningBoon()hook from its initializer.BrewingAutomataCorePeripheralaccepted that base boon and then attached anotherSCANNINGboon from its own initializer, causingBasePeripheralOwnerto reject the duplicate key.Fix
attachScanningBoon()in the Brewing peripheral, matching the established Mercantile peripheral pattern.How to Verify
turtlematic:starbound_brewing_automata.Test Plan
Risk Assessment
Low — the change uses an existing virtual customization hook and mirrors
MercantileAutomataCorePeripheral; it removes one duplicate registration without changing the boon contents.