fix: avoid duplicate brewing scanning boon - #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
Backport of #40 for the maintained Minecraft 1.20.1 line. A Brewing/Starbound Brewing upgraded turtle can register the
SCANNINGboon twice while initializing and crash the dedicated server.Root Cause
ExperienceAutomataCorePeripheralinvokes the virtualattachScanningBoon()hook from its initializer, whileBrewingAutomataCorePeripheralalso attached another boon with the same key in its own initializer.Fix
Override
attachScanningBoon()and register the richer Brewing scanning boon once through the existing superclass hook, matching the Mercantile implementation.Test Plan
Risk Assessment
Low — removes duplicate registration without changing boon contents.