Option to time unbinding - #121
Merged
Merged
Conversation
Collaborator
Author
|
First attempt at creating a timing figure... Blue lines are halo-level start and begin times. Black lines are subhalo-level times. Certainly not the most readable! 
|
Collaborator
Author
|
Cool thing is that we can start to look at trends of analyse time vs Nbound! |
Collaborator
Author
|
Also something new to see, which is the number of unbinding iterations subhaloes have been subject to. Some of them are quite high! 
|
robjmcgibbon
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbinding is one of the most expensive steps when creating subhalo catalogues. At the moment, we only provide the time it took for the slowest MPI rank to unbind all of the (sub)haloes it was assigned. This is not informative enough to understand what is driving the longest unbinding times, which could be further optimised in the future (e.g. #117 ).
This PR will add more fine grained timing information on a subhalo level. The idea is that the information will be sufficient to determine what is driving the largest cost and what could be changed to reduce the times.