Update docs for unbinding timing changes + misc - #124
Merged
Conversation
We always build particle hash
Binary gadget format does not require particle communication after reading halo particles. Hence, it remains untimed.
Collaborator
Author
|
The timers are now placed on similar places across I/O formats, and I have removed those which would always measure 0 seconds. gadget binary format does not require communication of halo particles, unlike apostle and swift formats. Hence, there is not I also removed the GSL parts of the code, which we have never used and were there to compute the eigenvalues of the inertia tensor. I think there are handier ways to do so, especially if we already provide the inertia tensors. |
VictorForouhar
marked this pull request as ready for review
September 26, 2025 09:45
Collaborator
Author
robjmcgibbon
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds docs for the changes in #121, and some example plots of how unbinding time scales with number of particles (neat!).
I have also restructured the docs a bit. I thought it was weird to talk about the
timing.logfile in the diagnostics instead of theOutputsection of the code. Hence, I moved it there.I also noticed a few additional things that should be addressed:
read_snapandread_haloare currently meaningless. For example,read_snapis stored immediately aftersnap_hash.halo_commsandhalo_io).