[Comgr][hotswap] Add SOPP + SOPC handlers#2553
Open
tgymnich wants to merge 1 commit into
Open
Conversation
Author
This was referenced May 15, 2026
9d870cf to
1c890b3
Compare
48995f5 to
85ca4bc
Compare
1c890b3 to
c0f8d72
Compare
85ca4bc to
e12639b
Compare
c0f8d72 to
6c0848a
Compare
e12639b to
64c274f
Compare
6c0848a to
59bb6f0
Compare
64c274f to
5f70dc8
Compare
59bb6f0 to
f866401
Compare
5f70dc8 to
d94dc16
Compare
f866401 to
c18d88f
Compare
d94dc16 to
9e9f3fc
Compare
c18d88f to
904a804
Compare
9e9f3fc to
dfe6b02
Compare
904a804 to
8396a7d
Compare
dfe6b02 to
f02d792
Compare
8396a7d to
ebecbd0
Compare
f02d792 to
bf64eb5
Compare
* handle_sopp.cpp — SOP_NoOperand / SOP_Subroutine entries:
s_endpgm, s_barrier, s_branch, s_cbranch_*, s_setprio, s_sleep,
s_waitcnt family, s_waitcnt_depctr/lgkmcnt/expcnt/vmcnt, plus
the gfx1250 s_wait_tensorcnt the VIMAGE handler later defers to.
* handle_sopc.cpp — scalar comparisons (s_cmp_eq_i32 / s_cmp_lt_u64
/ s_bitcmp1_b32 / ...) writing to SCC. Mirrors LLVM's
AMDGPUInstructions.td:1107 categorisation.
Both handlers are reachable through the in-progress dispatch loop
(landing later in `Wire raiser dispatcher`); the current
decode-and-bail raiser does not call them yet, but their TUs land in
the OBJECT lib so the dispatcher hook-up in the later commit becomes
a no-build-rebuild change.
Lit fixtures for SOPP/SOPC follow with the dispatcher commit since
they FileCheck the lifted IR shape, which depends on the dispatcher
actually calling these handlers.
Co-Authored-By: Tim Gymnich <tim@gymni.ch>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ebecbd0 to
80be9b5
Compare
bf64eb5 to
013d470
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both handlers are reachable through the in-progress dispatch loop (landing later in
Wire raiser dispatcher); the current decode-and-bail raiser does not call them yet, but their TUs land in the OBJECT lib so the dispatcher hook-up in the later commit becomes a no-build-rebuild change.Lit fixtures for SOPP/SOPC follow with the dispatcher commit since they FileCheck the lifted IR shape, which depends on the dispatcher actually calling these handlers.