Skip to content

[Comgr][hotswap] Add SOPP + SOPC handlers#2553

Open
tgymnich wants to merge 1 commit into
users/tgymnich/hotswap-pr-07-raise-clifrom
users/tgymnich/hotswap-pr-08-sopp-sopc-handlers
Open

[Comgr][hotswap] Add SOPP + SOPC handlers#2553
tgymnich wants to merge 1 commit into
users/tgymnich/hotswap-pr-07-raise-clifrom
users/tgymnich/hotswap-pr-08-sopp-sopc-handlers

Conversation

@tgymnich
Copy link
Copy Markdown

  • handle_sopp.cpp — SOP_NoOperand / SOP_Subroutine entries: s_endpgm, s_barrier, s_branch, s_cbranch_*, s_setprio, s_sleep, s_waitcnt family, s_waitcnt_depctr/lgkmcnt/expcnt/vmcnt, plus the gfx1250 s_wait_tensorcnt the VIMAGE handler later defers to.
  • handle_sopc.cpp — scalar comparisons (s_cmp_eq_i32 / s_cmp_lt_u64 / s_bitcmp1_b32 / ...) writing to SCC. Mirrors LLVM's AMDGPUInstructions.td:1107 categorisation.

Both handlers are reachable through the in-progress dispatch loop (landing later in Wire raiser dispatcher); the current decode-and-bail raiser does not call them yet, but their TUs land in the OBJECT lib so the dispatcher hook-up in the later commit becomes a no-build-rebuild change.

Lit fixtures for SOPP/SOPC follow with the dispatcher commit since they FileCheck the lifted IR shape, which depends on the dispatcher actually calling these handlers.

@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-07-raise-cli branch from 9d870cf to 1c890b3 Compare May 15, 2026 12:30
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-08-sopp-sopc-handlers branch from 48995f5 to 85ca4bc Compare May 15, 2026 12:31
@tgymnich tgymnich marked this pull request as ready for review May 15, 2026 12:33
@tgymnich tgymnich requested review from chinmaydd and lamb-j as code owners May 15, 2026 12:33
@tgymnich tgymnich requested review from ftynse and martin-luecke May 15, 2026 12:33
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-07-raise-cli branch from 1c890b3 to c0f8d72 Compare May 15, 2026 12:59
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-08-sopp-sopc-handlers branch from 85ca4bc to e12639b Compare May 15, 2026 12:59
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-07-raise-cli branch from c0f8d72 to 6c0848a Compare May 15, 2026 13:06
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-08-sopp-sopc-handlers branch from e12639b to 64c274f Compare May 15, 2026 13:06
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-07-raise-cli branch from 6c0848a to 59bb6f0 Compare May 15, 2026 15:28
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-08-sopp-sopc-handlers branch from 64c274f to 5f70dc8 Compare May 15, 2026 15:28
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-07-raise-cli branch from 59bb6f0 to f866401 Compare May 15, 2026 16:07
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-08-sopp-sopc-handlers branch from 5f70dc8 to d94dc16 Compare May 15, 2026 16:07
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-07-raise-cli branch from f866401 to c18d88f Compare May 15, 2026 16:19
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-08-sopp-sopc-handlers branch from d94dc16 to 9e9f3fc Compare May 15, 2026 16:19
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-07-raise-cli branch from c18d88f to 904a804 Compare May 15, 2026 18:55
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-08-sopp-sopc-handlers branch from 9e9f3fc to dfe6b02 Compare May 15, 2026 18:55
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-07-raise-cli branch from 904a804 to 8396a7d Compare May 15, 2026 20:46
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-08-sopp-sopc-handlers branch from dfe6b02 to f02d792 Compare May 15, 2026 20:46
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-07-raise-cli branch from 8396a7d to ebecbd0 Compare May 18, 2026 14:38
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-08-sopp-sopc-handlers branch from f02d792 to bf64eb5 Compare May 18, 2026 14:38
  * handle_sopp.cpp — SOP_NoOperand / SOP_Subroutine entries:
    s_endpgm, s_barrier, s_branch, s_cbranch_*, s_setprio, s_sleep,
    s_waitcnt family, s_waitcnt_depctr/lgkmcnt/expcnt/vmcnt, plus
    the gfx1250 s_wait_tensorcnt the VIMAGE handler later defers to.
  * handle_sopc.cpp — scalar comparisons (s_cmp_eq_i32 / s_cmp_lt_u64
    / s_bitcmp1_b32 / ...) writing to SCC. Mirrors LLVM's
    AMDGPUInstructions.td:1107 categorisation.

Both handlers are reachable through the in-progress dispatch loop
(landing later in `Wire raiser dispatcher`); the current
decode-and-bail raiser does not call them yet, but their TUs land in
the OBJECT lib so the dispatcher hook-up in the later commit becomes
a no-build-rebuild change.

Lit fixtures for SOPP/SOPC follow with the dispatcher commit since
they FileCheck the lifted IR shape, which depends on the dispatcher
actually calling these handlers.

Co-Authored-By: Tim Gymnich <tim@gymni.ch>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-07-raise-cli branch from ebecbd0 to 80be9b5 Compare May 18, 2026 15:00
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-08-sopp-sopc-handlers branch from bf64eb5 to 013d470 Compare May 18, 2026 15:00
@chinmaydd chinmaydd added comgr Related to Code Object Manager hotswap Related to the Comgr Hotswap feature labels May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comgr Related to Code Object Manager hotswap Related to the Comgr Hotswap feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants