Skip to content

[Comgr][hotswap] Add wave projection + ISA profile + abi/wave-mask docs#2518

Open
tgymnich wants to merge 1 commit into
users/tgymnich/hotswap-pr-04-decoderfrom
users/tgymnich/hotswap-pr-05-raise-context
Open

[Comgr][hotswap] Add wave projection + ISA profile + abi/wave-mask docs#2518
tgymnich wants to merge 1 commit into
users/tgymnich/hotswap-pr-04-decoderfrom
users/tgymnich/hotswap-pr-05-raise-context

Conversation

@tgymnich
Copy link
Copy Markdown

@tgymnich tgymnich commented May 13, 2026 •
edited
Loading

  • wave_projection.{h,cpp} — WaveProjection interface + the three
    concrete projections (ThreadLoopProjection,
    WaveNativeProjection, ModuloReplicationProjection) the raiser
    selects between to bridge wave32 -> wave64 cross-widening. Also
    holds the instructionWritesEXEC predicate and the per-projection
    emitLaneActiveBit helper handlers consume.
  • isa_profile.h — ISAProfile snapshots the wave-direction-relevant
    capability bits (wave size, AGPRs/MFMA, VOPD, FP8 conversion,
    gfx950 MAI, gfx1250 TENSOR ops, ...) for a given subtarget.
    WaveProjection consumes source/target ISAProfiles to pick the
    correct projection policy.
  • docs/abi-translation.md — wave32 <-> wave64 ABI translation
    contract (kernarg layout, user-SGPR seeding, scratch / private
    segment, hidden args).
  • docs/sgpr-wave-mask-translation.md — SGPR-as-wave-mask handling
    rules referenced by handle_valu_vcmp.cpp (lands later).

@tgymnich
Copy link
Copy Markdown
Author

tgymnich commented May 13, 2026 •
edited
Loading

Warning

Stacked PR

  1. [Comgr][hotswap] Add bare-bones hotswap transpiler scaffolding #2438
  2. [Comgr][hotswap] Add code-object metadata parsing #2437
  3. [Comgr][hotswap] Add AMDGPU MC state setup #2439
  4. [Comgr][hotswap] Add DecodedInst + basic kernel decoder #2517
  6. [Comgr][hotswap] Add raise_failure + RaiseContext + register file #2551
  7. [Comgr][hotswap] Add raise_cli + lit harness for hotswap-raise fixtures #2552
  8. [Comgr][hotswap] Add SOPP + SOPC handlers #2553

This was referenced May 13, 2026
Open
Open
Merged
Open
Open
@tgymnich tgymnich changed the title [Comgr][hotswap] Add raise_failure + RaiseContext + register file + I… [Comgr][hotswap] Add raise_failure + RaiseContext + register file + ISA profile May 13, 2026
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-05-raise-context branch 2 times, most recently from 35108c8 to d5577b3 Compare May 13, 2026 14:51
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-04-decoder branch from 6e6f193 to 4d23bed Compare May 13, 2026 15:40
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-05-raise-context branch from d5577b3 to 5d470dd Compare May 13, 2026 15:40
@tgymnich tgymnich requested a review from martin-luecke May 13, 2026 15:56
@lamb-j lamb-j added the hotswap Related to the Comgr Hotswap feature label May 14, 2026
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-04-decoder branch from 4d23bed to f434f7f Compare May 15, 2026 11:16
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-05-raise-context branch from 5d470dd to a006842 Compare May 15, 2026 11:16
@tgymnich tgymnich marked this pull request as ready for review May 15, 2026 11:35
@tgymnich tgymnich requested review from chinmaydd and lamb-j as code owners May 15, 2026 11:35
This was referenced May 15, 2026
Open
Open
Open
@tgymnich tgymnich requested a review from ftynse May 15, 2026 11:45
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-04-decoder branch from f434f7f to 5b815e6 Compare May 15, 2026 13:06
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-05-raise-context branch from a006842 to fbda441 Compare May 15, 2026 13:06
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-04-decoder branch from 5b815e6 to 634765b Compare May 15, 2026 15:28
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-05-raise-context branch from fbda441 to dcbd299 Compare May 15, 2026 15:28
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-04-decoder branch from 634765b to a32b336 Compare May 15, 2026 16:07
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-05-raise-context branch from dcbd299 to a3e1f92 Compare May 15, 2026 16:07
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-04-decoder branch from a32b336 to 5249422 Compare May 15, 2026 16:18
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-05-raise-context branch from a3e1f92 to b30be20 Compare May 15, 2026 16:18
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-04-decoder branch from 5249422 to eac9fc5 Compare May 15, 2026 18:55
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-05-raise-context branch from b30be20 to d303c65 Compare May 15, 2026 18:55
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-04-decoder branch from eac9fc5 to c1bbdbf Compare May 15, 2026 20:46
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-05-raise-context branch 2 times, most recently from b8a59da to 716a86f Compare May 18, 2026 14:38
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-04-decoder branch from c1bbdbf to 36b17dd Compare May 18, 2026 14:38
@tgymnich tgymnich changed the title [Comgr][hotswap] Add raise_failure + RaiseContext + register file + ISA profile [Comgr][hotswap] Add wave projection + setpc analysis + ISA profile + abi/sync docs May 18, 2026
@martin-luecke @tgymnich @claude
[Comgr][hotswap] Add wave projection + ISA profile + abi/wave-mask docs
bb73f44 
  * wave_projection.{h,cpp} — `WaveProjection` interface + the three
    concrete projections (`ThreadLoopProjection`,
    `WaveNativeProjection`, `ModuloReplicationProjection`) the raiser
    selects between to bridge wave32 -> wave64 cross-widening. Also
    holds the `instructionWritesEXEC` predicate and the per-projection
    `emitLaneActiveBit` helper handlers consume.
  * isa_profile.h — `ISAProfile` snapshots the wave-direction-relevant
    capability bits (wave size, AGPRs/MFMA, VOPD, FP8 conversion,
    gfx950 MAI, gfx1250 TENSOR ops, ...) for a given subtarget.
    `WaveProjection` consumes source/target `ISAProfile`s to pick the
    correct projection policy.
  * docs/abi-translation.md — wave32 <-> wave64 ABI translation
    contract (kernarg layout, user-SGPR seeding, scratch / private
    segment, hidden args).
  * docs/sgpr-wave-mask-translation.md — SGPR-as-wave-mask handling
    rules referenced by handle_valu_vcmp.cpp (lands later).

Co-Authored-By: Tim Gymnich <tim@gymni.ch>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@tgymnich tgymnich force-pushed the users/tgymnich/hotswap-pr-05-raise-context branch from 716a86f to bb73f44 Compare May 18, 2026 14:48
@tgymnich tgymnich changed the title [Comgr][hotswap] Add wave projection + setpc analysis + ISA profile + abi/sync docs [Comgr][hotswap] Add wave projection + ISA profile + abi/wave-mask docs May 18, 2026
@tgymnich tgymnich mentioned this pull request May 18, 2026
Open
@chinmaydd chinmaydd added the comgr Related to Code Object Manager label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-luecke martin-luecke Awaiting requested review from martin-luecke

@lamb-j lamb-j Awaiting requested review from lamb-j lamb-j is a code owner

@chinmaydd chinmaydd Awaiting requested review from chinmaydd chinmaydd is a code owner

@ftynse ftynse Awaiting requested review from ftynse

Assignees

No one assigned

Labels

comgr Related to Code Object Manager hotswap Related to the Comgr Hotswap feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tgymnich @ftynse @chinmaydd @lamb-j @martin-luecke