fix(snowflake): quote the dropped column name with double quotes - #2169
Closed
Aias00 wants to merge 1 commit into
Closed
fix(snowflake): quote the dropped column name with double quotes#2169Aias00 wants to merge 1 commit into
Aias00 wants to merge 1 commit into
Conversation
DROP COLUMN emitted the name unquoted; Snowflake uppercases unquoted identifiers, so mixed-case columns couldn't be dropped. Use double-quote quoting, mirroring PostgreSQL and Snowflake's own buildCreateColumnSql. Fixes OtterMind#2166 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
Live-database verification (PostgreSQL 16)Same bug class verified against PostgreSQL 16:
Snowflake has the same uppercasing behavior for unquoted identifiers. |
Contributor
Author
Aias00
added a commit
to Aias00/Chat2DB
that referenced
this pull request
Jul 27, 2026
…ENAME Replaces direct " concatenation with SnowflakeMetaData.SNOWFLAKE_SQL_IDENTIFIER_PROCESSOR.quoteIdentifierAlways for DROP COLUMN, CREATE TABLE schema qualifier, and RENAME COLUMN. CHANGE COLUMN (MySQL syntax) is replaced with RENAME COLUMN (Snowflake). Built on the SPI extension (OtterMind#2234). Closes OtterMind#2169, OtterMind#2185, OtterMind#2186 (superseded by this SPI-based approach) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2166
Summary
Snowflake DROP COLUMN emitted the name unquoted (SQL_DROP_COLUMN = "DROP COLUMN "); Snowflake uppercases unquoted identifiers, so a mixed-case column ("myCol") couldn't be dropped (resolves to MYCOL and fails). Changed the constant to include the opening double-quote and append the closing one, mirroring PostgreSQL and Snowflake's own buildCreateColumnSql.
Verification
Contributor declaration
AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.