fix(postgresql,kingbase): quote foreign schema and table in REFERENCES#2187
Open
Aias00 wants to merge 1 commit into
Open
fix(postgresql,kingbase): quote foreign schema and table in REFERENCES#2187Aias00 wants to merge 1 commit into
Aias00 wants to merge 1 commit into
Conversation
The foreign schema and table were concatenated raw while the foreign columns below were double-quoted. PostgreSQL/KingBase fold unquoted identifiers to lowercase, so mixed-case foreign table names produced a REFERENCES clause pointing at a non-existent relation. Wrap in double-quotes, matching the column quoting in the same method. Fixes OtterMind#2184 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
Live-database verification (PostgreSQL 16)
The foreign columns were already double-quoted in the same method; this fix quotes the schema and table to match. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2184
Summary
PostgreSQLIndexTypeEnum.buildForeignColum (and the identical KingBaseIndexTypeEnum) concatenated getForeignSchemaName() and getForeignTableName() raw into the REFERENCES clause, while the foreign columns below were double-quoted. PostgreSQL/KingBase fold unquoted identifiers to lowercase, so a foreign table with an uppercase/mixed-case name produced a REFERENCES clause pointing at a non-existent relation. Wrapped both in double-quotes, matching the column quoting in the same method. Applied to both PostgreSQL and KingBase.
Verification
Contributor declaration
AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.