fix(rvv decode): add inst[14:12] constraint on vlm/vsm#1060
Open
skyhgzsh wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Tightens RVV load/store decode patterns so vlm/vsm (mask load/store) only match when inst[14:12] (the width/funct3 field for vector loads/stores) is 000, preventing reserved/other-width encodings from being incorrectly executed as mask operations.
Changes:
- Constrain
vlmdecode pattern to requireinst[14:12] == 000(direct + MMU paths). - Constrain
vsmdecode pattern to requireinst[14:12] == 000(direct + MMU paths).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NEMU Performance Results - XS Interpreter
NEMU Performance Results - XS Ref Shared Object
|
poemonsense
approved these changes
Jun 9, 2026
poemonsense
reviewed
Jun 9, 2026
poemonsense
left a comment
Member
There was a problem hiding this comment.
I don't know the vector load/store instructions and should not approve this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.