[mlir] Update tests for the dispatcher debug revert strings - #168
Merged
Conversation
This was referenced Jul 24, 2026
Merged
abinavpp
marked this pull request as ready for review
July 25, 2026 13:55
There was a problem hiding this comment.
Pull request overview
Updates the MLIR EVM test expectations to match the current “dispatcher debug revert strings” behavior (per the linked solx-llvm change), and unblocks semantic tests that no longer fail.
Changes:
- Remove two revert-string semantic tests from
mlirSemtestFailures.txt(they’re no longer expected to fail). - Update
FileCheckexpectations inrevert-strings.solfor--revert-strings debugto reflect the new revert-data construction (writingError(string)ABI payload beforeevm.revert).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/mlirSemtestFailures.txt | Drops two revert-string tests from the known-failures list. |
| test/lit/mlirCodegen/EVM/revert-strings.sol | Updates DEBUG-mode MLIR FileCheck assertions to match new revert-string emission in dispatcher paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abinavpp
force-pushed
the
app-dispatcher-revert-strings
branch
from
July 27, 2026 18:45
c0dd359 to
e4cc518
Compare
abinavpp
force-pushed
the
app-lowering-sem-fixes
branch
from
July 27, 2026 18:45
a6c3583 to
846b187
Compare
abinavpp
force-pushed
the
app-lowering-sem-fixes
branch
from
July 28, 2026 12:45
846b187 to
9a21c77
Compare
abinavpp
force-pushed
the
app-dispatcher-revert-strings
branch
from
July 28, 2026 12:45
e4cc518 to
de4405d
Compare
abinavpp
force-pushed
the
app-dispatcher-revert-strings
branch
5 times, most recently
from
July 28, 2026 12:54
620478a to
0a8d054
Compare
abinavpp
force-pushed
the
app-dispatcher-revert-strings
branch
from
July 28, 2026 12:55
0a8d054 to
0df886e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NomicFoundation/solx-llvm#128