Skip to content

[mlir] Update tests for the dispatcher debug revert strings - #166

Closed
abinavpp wants to merge 1 commit into
app-lowering-sem-fixesfrom
app-viair-parity
Closed

[mlir] Update tests for the dispatcher debug revert strings#166
abinavpp wants to merge 1 commit into
app-lowering-sem-fixesfrom
app-viair-parity

Conversation

@abinavpp

@abinavpp abinavpp commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the MLIR (via-IR) test expectations and failure allowlist to reflect recent value-cleanup behavior (masking/cleaning narrow types, bool normalization) and updated revert-string dispatcher codegen, aligning test baselines with the current IR output.

Changes:

  • Refresh MLIR codegen lit CHECK/DEBUG baselines across multiple EVM-focused tests (bytes/fixedbytes/address/bool/array/arith/magic/revert-strings) to match updated lowering patterns and inserted cleanup operations.
  • Update MLIR semantic test expected outputs where behavior has changed due to value cleanups (e.g., uint8 bitwise NOT results and dirty-memory static array cleanup).
  • Remove tests from mlirSemtestFailures.txt that now pass, and adjust the remaining entry set accordingly.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/mlirSemtestFailures.txt Updates the semtest failure allowlist to reflect newly passing tests and remaining known failures.
test/lit/mlirCodegen/EVM/revert-strings.sol Updates DEBUG IR checks for revised revert-string construction/dispatch patterns.
test/lit/mlirCodegen/EVM/magic.sol Updates CHECK patterns to match new masking/cleanup behavior in generated IR.
test/lit/mlirCodegen/EVM/load-store-memory-cleanup.sol Updates CHECK patterns to include new cleanup (masking/signextend) operations around loads/stores.
test/lit/mlirCodegen/EVM/fixedbytes.sol Updates CHECK patterns to include masking after bitwise ops for fixed-bytes values.
test/lit/mlirCodegen/EVM/fixedbytes-memory-store.sol Updates CHECK patterns to include masking on loaded fixed-bytes values returned from memory.
test/lit/mlirCodegen/EVM/bytes.sol Updates CHECK patterns to include masking for bytes-related values.
test/lit/mlirCodegen/EVM/byte-type.sol Updates CHECK patterns to include additional masking after bitwise operations.
test/lit/mlirCodegen/EVM/bool-cleanup.sol Updates CHECK patterns to normalize loaded bools via compare + ext.
test/lit/mlirCodegen/EVM/array.sol Minor CHECK update to align loc annotation with surrounding IR.
test/lit/mlirCodegen/EVM/array-decode.sol Updates CHECK patterns to include masking for decoded narrow types.
test/lit/mlirCodegen/EVM/arith.sol Updates CHECK patterns for masked bytes ops and adjusted signextend sequencing / revert blocks.
test/lit/mlirCodegen/EVM/address-cast.sol Updates CHECK patterns to include address-masking on cast results.
test/libsolidity/semanticTests/mlir/dirty-memory-static-array.sol Updates expected result to true now that the loaded uint8 value is properly cleaned.
test/libsolidity/semanticTests/mlir/arith.sol Updates expected results for f(uint8) to show cleaned uint8 (~1 => 0xfe) consistently in both outputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/mlirSemtestFailures.txt Outdated
@abinavpp
abinavpp changed the base branch from app-lowering-fixes to app-lowering-sem-fixes July 23, 2026 07:30
@abinavpp
abinavpp force-pushed the app-viair-parity branch 2 times, most recently from 6c2f7ba to 0008163 Compare July 24, 2026 14:41
@abinavpp abinavpp changed the title [mlir] Via-IR parity: value cleanups and dispatcher revert strings [mlir] Clean values at the producing ops and emit dispatcher guard revert strings Jul 24, 2026
@abinavpp abinavpp changed the title [mlir] Clean values at the producing ops and emit dispatcher guard revert strings [mlir] Update tests for the dispatcher debug revert strings Jul 24, 2026
@abinavpp abinavpp closed this Jul 24, 2026
@abinavpp
abinavpp deleted the app-viair-parity branch July 24, 2026 14:56
@abinavpp

Copy link
Copy Markdown
Contributor Author

Branch rename deleted the head ref, which made GitHub close this PR. Continued in #168.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants