Fix strncpy truncation warning and cppcheck index-before-check error#3893
Open
BsAtHome wants to merge 1 commit intoLinuxCNC:masterfrom
Open
Fix strncpy truncation warning and cppcheck index-before-check error#3893BsAtHome wants to merge 1 commit intoLinuxCNC:masterfrom
BsAtHome wants to merge 1 commit intoLinuxCNC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer GCC starts to complain even more about inappropriate use of strncpy when it obviously truncates. In this case a simple char type is appropriate instead of copying a string in to a buffer of length 1 (Tcl_GetStringFromObj always returns a valid buffer).
The second fix is a cppcheck error noting that an array index was used before the index was checked (in one expression). The expression has been rewritten to perform the index test before the index.