Skip to content

feat(runner): add --extra-mount option to runc.sh #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkoura merged 1 commit into from
Apr 8, 2026
+8 −2
Merged

feat(runner): add --extra-mount option to runc.sh #3392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions runner/runc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
# Usage:
# ./runc.sh [--nixos-container[=VERSION]] [--ubuntu-container[=VERSION]]
# [--debian-container[=VERSION]] [--mint-container[=VERSION]]
# [--extra-mount=HOST_PATH:CONTAINER_PATH]
# '<command>'
#
# Options:
Expand All @@ -20,6 +21,9 @@
# VERSION is the image tag, e.g. 'bookworm'.
# --mint-container[=VERSION] Use a Linux Mint container (requires host
# /nix). VERSION is the image tag.
# --extra-mount=HOST_PATH:CONTAINER_PATH Bind-mount an additional path from
# the host into the container. Can be specified
# multiple times to mount multiple paths.
# See:
# * NixOS: <https://hub.docker.com/r/nixos/nix/tags>
# * Ubuntu: <https://hub.docker.com/_/ubuntu/tags>
Expand All @@ -42,8 +46,9 @@ else
exit 1
fi

CONTAINER_TYPE="" # empty = auto-detect; nixos, ubuntu, debian, mint
CONTAINER_TYPE="" # empty = auto-detect
CONTAINER_VERSION="latest"
EXTRA_MOUNTS=()

while [ $# -gt 0 ]; do
case "$1" in
Expand All @@ -55,6 +60,8 @@ while [ $# -gt 0 ]; do
--debian-container=*) CONTAINER_TYPE="debian"; CONTAINER_VERSION="${1#*=}"; shift ;;
--mint-container) CONTAINER_TYPE="mint"; shift ;;
--mint-container=*) CONTAINER_TYPE="mint"; CONTAINER_VERSION="${1#*=}"; shift ;;
--extra-mount=*) EXTRA_MOUNTS+=("-v" "${1#*=}"); shift ;;
--) shift; break ;;
*) break ;;
esac
done
Expand All @@ -74,7 +81,6 @@ REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
# When running from a git worktree, .git is a file referencing the main repo's
# .git directory. The path it points to won't exist inside the container unless
# we also mount the main .git directory at the same absolute path.
EXTRA_MOUNTS=()
if [ -f "$REPO_DIR/.git" ]; then
GITDIR="$(sed -n 's/^gitdir: //p' "$REPO_DIR/.git" | head -n 1)"
if [ -n "$GITDIR" ]; then
Expand Down