feat(runner): add --extra-mount option to runc.sh#3392
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for specifying additional volume mounts when running containers by introducing a new --extra-mount CLI option in runner/runc.sh.
Changes:
- Introduces an
EXTRA_MOUNTSarray to accumulate user-provided mount flags. - Adds CLI parsing for
--extra-mount(plus--to end option parsing). - Removes a duplicate
EXTRA_MOUNTSinitialization later in the script.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mkoura
force-pushed
the
add_extra_mounts
branch
2 times, most recently
from
60eb789 to
93d467b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Introduce the --extra-mount argument to allow users to specify additional volume mounts when running containers. This enhances flexibility for mounting custom paths into the container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the --extra-mount argument to allow users to specify additional volume mounts when running containers. This enhances flexibility for mounting custom paths into the container.