fix(prefill): atomically reserve and publish snapshots - #187
Merged
Conversation
Reserve worker cache capacity before expensive compute, protect it from adaptive shrink, and atomically lease the final snapshot so completed full-context Prefill cannot be evicted before discovery. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Exercise every atomic publish and capacity guard while making public cache writes respect active reservations. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.0.0.0:51051so allens can reach its advertised Thunderbolt addressRoot cause
The failed full-context Critic completed roughly 1,200 seconds of model compute, then published snapshots one by one into a 256 MiB adaptive LRU. Concurrent adaptive shrink and 66 evictions (1.07 GiB evicted) removed the final snapshot before the subsequent lookup/lease, producing
computed snapshot was not discoverable.Correctness guarantees
Tests
Made with Cursor