fix(prefill): preserve unrelated snapshots during jobs - #188
Merged
Conversation
Reserve only the conservative final-snapshot estimate so atomic publication remains protected without erasing Generator or prior Critic snapshots needed for cold restore. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The first real full-context run succeeded after PR #187, but its full-budget reservation evicted every existing snapshot at each new job. A later Generator miss therefore erased the prior Critic snapshot, preventing cold restore despite correct atomic publication.
For the measured 1,010-token Critic, the configured reservation is about 404 MB while the actual imported final snapshot is roughly 90 MB. The 1+ GiB cache budget safely accommodates the estimate and unrelated snapshots.
Tests
Made with Cursor