Skip to content

[codex] Add missing model Electron download UI regression test#1692

Draft
benceruleanlu wants to merge 1 commit into
mainfrom
bl/missing-model-download-ui-test
Draft

[codex] Add missing model Electron download UI regression test#1692
benceruleanlu wants to merge 1 commit into
mainfrom
bl/missing-model-download-ui-test

Conversation

@benceruleanlu
Copy link
Copy Markdown
Member

@benceruleanlu benceruleanlu commented Apr 17, 2026

Summary

  • add a post-install Electron regression test for missing-model direct downloads
  • reproduce the desktop path where the button should switch from Download to active/imported UI states
  • assert the downloaded file lands in the expected models directory

Why

Prod downloads were succeeding in Electron, but the Missing Models row stayed in the default Download UI state. This PR captures that regression at the desktop app level before the frontend fix is consumed.

Impact

This PR is intended to be the red test in the stack. The current released desktop frontend does not reflect direct Electron download progress in this UI path, so this spec should fail until the frontend fix lands.

Validation

  • yarn prettier --write tests/integration/post-install/missingModelDownloadUi.spec.ts
  • yarn eslint tests/integration/post-install/missingModelDownloadUi.spec.ts --fix
  • attempted: COMFYUI_ENABLE_VOLATILE_TESTS=1 yarn playwright test tests/integration/post-install/missingModelDownloadUi.spec.ts --project post-install

Notes

The Playwright run did not complete cleanly in the local environment because the existing post-install setup timed out and teardown hit EPERM: operation not permitted, scandir '/Users/ben/Documents/ComfyUI'. That blocked a clean local red/green confirmation, but the spec itself is in place for CI.

┆Issue is synchronized with this Notion page by Unito

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0ee1dec7-7e1e-4415-b330-d8e55ce97e4a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bl/missing-model-download-ui-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant