[codex] Add missing model Electron download UI regression test#1692
Draft
benceruleanlu wants to merge 1 commit into
Draft
[codex] Add missing model Electron download UI regression test#1692benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Downloadto active/imported UI statesWhy
Prod downloads were succeeding in Electron, but the Missing Models row stayed in the default
DownloadUI state. This PR captures that regression at the desktop app level before the frontend fix is consumed.Impact
This PR is intended to be the red test in the stack. The current released desktop frontend does not reflect direct Electron download progress in this UI path, so this spec should fail until the frontend fix lands.
Validation
yarn prettier --write tests/integration/post-install/missingModelDownloadUi.spec.tsyarn eslint tests/integration/post-install/missingModelDownloadUi.spec.ts --fixCOMFYUI_ENABLE_VOLATILE_TESTS=1 yarn playwright test tests/integration/post-install/missingModelDownloadUi.spec.ts --project post-installNotes
The Playwright run did not complete cleanly in the local environment because the existing post-install setup timed out and teardown hit
EPERM: operation not permitted, scandir '/Users/ben/Documents/ComfyUI'. That blocked a clean local red/green confirmation, but the spec itself is in place for CI.┆Issue is synchronized with this Notion page by Unito