Skip to content

[codex] Consume frontend missing model download UI fix#1693

Closed
benceruleanlu wants to merge 1 commit into
bl/missing-model-download-ui-testfrom
bl/missing-model-download-ui-consume-fix
Closed

[codex] Consume frontend missing model download UI fix#1693
benceruleanlu wants to merge 1 commit into
bl/missing-model-download-ui-testfrom
bl/missing-model-download-ui-consume-fix

Conversation

@benceruleanlu
Copy link
Copy Markdown
Member

@benceruleanlu benceruleanlu commented Apr 17, 2026

Summary

  • point the desktop build at bl/missing-model-download-ui-fix via config.frontend.optionalBranch
  • let the desktop regression-test stack consume the frontend fix before a tagged frontend release exists

Why

The UI fix lives in ComfyUI_frontend, but the red regression test lives in desktop. This bridge PR makes the desktop branch build against the frontend fix branch so the stack can demonstrate red then green without waiting for a release cut.

Stack

Notes

This is intentionally temporary. Once the frontend fix is merged and released, desktop should go back to consuming a tagged frontend release instead of an optionalBranch override.

Validation

  • yarn prettier --check package.json

┆Issue is synchronized with this Notion page by Unito

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 686629ff-6f19-42f2-a3c4-9d9c7a4db097

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bl/missing-model-download-ui-consume-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@benceruleanlu
Copy link
Copy Markdown
Member Author

Forgot CI doesn't run on non main branches. Will just make it a commit on the lower PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant