Skip to content

return error when all transparent address indexes are in use #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Oscar-Pepper wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

return error when all transparent address indexes are in use #2402

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73e7c4f
return error when all transparent address indexes are in use
Oscar-Pepper Jun 13, 2026
c22b472
correctly update address index
Oscar-Pepper Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions pepper-sync/src/sync/transparent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,20 +109,18 @@ pub(crate) async fn update_addresses_and_scan_targets<W: SyncWallet>(
.filter(|id| id.account_id() == *account_id && id.scope() == *scope)
.next_back()
{
id.address_index().index() + 1
id.address_index().next()
} else {
0
};
Some(NonHardenedChildIndex::ZERO)
}
.ok_or_else(|| {
SyncError::TransparentAddressDerivationError(bip32::Error::ChildNumber)
})?;
let mut unused_address_count: usize = 0;
let mut addresses: Vec<(TransparentAddressId, String)> = Vec::new();

while unused_address_count < config.gap_limit as usize {
let address_id = TransparentAddressId::new(
*account_id,
*scope,
NonHardenedChildIndex::from_index(address_index)
.expect("all non-hardened addresses in use!"),
);
let address_id = TransparentAddressId::new(*account_id, *scope, address_index);
let address = keys::transparent::derive_address(
consensus_parameters,
account_pubkey,
Expand Down Expand Up @@ -152,7 +150,9 @@ pub(crate) async fn update_addresses_and_scan_targets<W: SyncWallet>(
unused_address_count = 0;
}

address_index += 1;
address_index = address_index.next().ok_or_else(|| {
SyncError::TransparentAddressDerivationError(bip32::Error::ChildNumber)
})?;
}

addresses.truncate(addresses.len() - config.gap_limit as usize);
Expand Down
Loading