[DEV-7573] Refactor rmqstream library - #26
Merged
Conversation
RabidGhost
force-pushed
the
DEV-7573-rmqstream-refactor
branch
from
March 2, 2026 07:03
5f3289e to
3db631d
Compare
RabidGhost
marked this pull request as ready for review
March 3, 2026 05:19
rmqstream library
- Remove potential UB with `static mut` - Update rust editon and remove unused dependencies - Make sure tracing and logging are initialised Signed-off-by: Mitchell Browne <mitchell.browne@zepben.com>
RabidGhost
force-pushed
the
DEV-7573-rmqstream-refactor
branch
from
March 4, 2026 00:34
4f63888 to
c47e980
Compare
zarakay
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor the
rmqstreamrust library. The main goal of the refactor is to bring the library to the 2024 edition, update the rust version to 1.93.1 (latest at time of writing), and update all dependencies to latest versions.In addition to refactors,
load_balancer_mode(true)has been enabled on the RabbitMQ producer. This is not strictly nessesary as stream hostname resolution has now been updated for namespaced hosting capacity service.Tests have been for logging and tracing setup.
Update to the 2024 edition
In the 2024 editon,
static mutis disallowed (an error lint by default). It is very tricky to reason about correctly. We have moved to usingstaticandMutexs.Remove unused dependencies
futurescrate was unusedlazy_staticfunctionality is now included in the standard libraryUpdate to Rust 1.93.1
No issues in upgrading to the latest Rust version. Means all dependencies can go to latest without any issues.
Associated tasks
None
Test Steps
The changes have been tested on staging, and tests for logging have been added. Other tests should be part of the calling code, or the HCS integration tests.
Checklist
Code
Security
When developing applications, use following guidelines for information security considerations:
Documentation
I have updated the changelog.I have updated any documentation required for these changes.Breaking Changes
None