Skip to content

Fix chart resolution bug #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
facetoe merged 1 commit into from
Jul 24, 2026
Merged

Fix chart resolution bug #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions local-k8s/src/local_k8s/commands/chart/lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@ def lint(helm_dir: Path, chart: Path) -> None:

resolved_chart = resolve_chart(helm_dir, chart)
ct_config = ChartTestingConfig.from_chart_dir(helm_dir)
chart_metadata = ChartMetadata.from_chart_dir(
resolved_chart.path_relative_to_helm_dir
)
chart_metadata = ChartMetadata.from_chart_dir(resolved_chart.absolute_path)
validate_dependencies_present(chart_metadata, ct_config, ct_path)
with chdir(helm_dir):
try:
Expand All @@ -64,6 +62,10 @@ def validate_dependencies_present(
# Syntax is <name>=<url>
chart_repos = [repo.split("=")[-1] for repo in ct_config.chart_repos]
for dependency in chart_metadata.dependencies:
# helm pulls OCI deps from the url in Chart.yaml during dependency build without helm repo add,
# so no need for us to validate it's existence in chart repos.
if dependency.repository.startswith("oci://ghcr.io"):
continue
if dependency.repository not in chart_repos:
raise ClickException(
f"{dependency.repository} not found in {ct_path}. It needs to be added under the chart_repos list, in the format <name>=<url>"
Expand Down