Skip to content

PuzzleInfo reconstruction #3146

Open
Luzagar wants to merge 2 commits intozeldaret:mainfrom
Luzagar:save_info
Open

PuzzleInfo reconstruction #3146
Luzagar wants to merge 2 commits intozeldaret:mainfrom
Luzagar:save_info

Conversation

@Luzagar
Copy link
Copy Markdown
Contributor

@Luzagar Luzagar commented Apr 9, 2026

get those name from tww decomp

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Apr 9, 2026

Report for GZ2J01 (5685fa5 - 8033ec9)

No changes

Report for GZ2E01 (5685fa5 - 8033ec9)

No changes

Report for GZ2P01 (5685fa5 - 8033ec9)

No changes

Report for Shield (5685fa5 - 8033ec9)

No changes

Report for RZDE01_00 (5685fa5 - 8033ec9)

No changes

Report for DZDE01 (5685fa5 - 8033ec9)

No changes

Report for RZDE01_02 (5685fa5 - 8033ec9)

No changes

Report for ShieldD (5685fa5 - 8033ec9)

No changes

Report for RZDJ01 (5685fa5 - 8033ec9)

No changes

Report for RZDP01 (5685fa5 - 8033ec9)

No changes

@Luzagar Luzagar closed this Apr 9, 2026
@Luzagar Luzagar reopened this Apr 9, 2026
@Luzagar Luzagar changed the title Add PuzzleInfo PuzzleInfo reconstruction Apr 9, 2026
/* 0x35 */ u8 unk53;
/* 0x36 */ u8 mClearCount;
/* 0x37 */ u8 unk55[5];
/* 0x37 */ u8 mPuzzleData[5];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that this field is a leftover of mPuzzleData from TWW? It's a different length and in a different position within the struct. Could be a completely different field, no?
https://github.com/zeldaret/tww/blob/fe4ca85c7988b8206f225849d42de9edbff5fd20/include/d/d_save.h#L453-L455

Copy link
Copy Markdown
Contributor Author

@Luzagar Luzagar Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reasoning was that they are close to each other, and also it's the only field with a loop initialization. tp debug, only read ClearCount, which was used for obj_apzl in tww but yeah, that's a guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants