PoC: Migrate to Official Go MCP SDK - #1
Conversation
Migrates the project to use `github.com/modelcontextprotocol/go-sdk` instead of `github.com/mark3labs/mcp-go`. Changes: - Replaced SDK dependency in `go.mod`. - Refactored `cmd/server/main.go` and `internal/server/server.go` to initialize the new server. - Implemented typed argument structs in `internal/vault/types.go` for `list-notes` and `write-note`. - Updated `ListNotesHandler` and `WriteNoteHandler` in `internal/vault/vault.go` to use the new generic `mcp.AddTool` pattern with automatic argument unmarshaling and validation. - Temporarily commented out other tool handlers and disabled `editing_test.go` to allow compilation and verification of the PoC. Verification: - Confirmed `list-notes` and `write-note` function correctly with the new SDK using a local test client. Co-authored-by: zach-snell <10632545+zach-snell@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Migrates the project to use `github.com/modelcontextprotocol/go-sdk` instead of `github.com/mark3labs/mcp-go`. Changes: - Replaced SDK dependency in `go.mod` (downgraded to go 1.24 to match linter/env). - Refactored `cmd/server/main.go` and `internal/server/server.go` to initialize the new server. - Implemented typed argument structs in `internal/vault/types.go` for `list-notes` and `write-note`. - Updated `ListNotesHandler` and `WriteNoteHandler` in `internal/vault/vault.go` to use the new generic `mcp.AddTool` pattern with automatic argument unmarshaling and validation. - Temporarily commented out other tool handlers and disabled `editing_test.go` to allow compilation and verification of the PoC. Verification: - Confirmed `list-notes` and `write-note` function correctly with the new SDK using a local test client. - Ran `golangci-lint` and `govulncheck`. Co-authored-by: zach-snell <10632545+zach-snell@users.noreply.github.com>
|
Superseded by sdk-migration/ready-for-review branch which includes this work plus lint fixes and missing handler registrations. |
Acknowledged. |
1 participant
This PR initiates the migration to the official Go MCP SDK (
github.com/modelcontextprotocol/go-sdk).It serves as a Proof of Concept (PoC) demonstrating the benefits of the new SDK, particularly the type-safe, struct-based argument parsing which simplifies handler logic and improves safety.
Key Changes:
mark3labs/mcp-gowithmodelcontextprotocol/go-sdk.list-notesandwrite-notetools.ListNotesArgsandWriteNoteArgsstructs for automatic validation.Next Steps (Post-Merge):
internal/vault/editing_test.goand other tests.go.modcleanup.PR created automatically by Jules for task 16652907104557779702 started by @zach-snell