Additional models, for additional Palo Alto models#3813
Open
athompson-merlin wants to merge 5 commits intoytti:masterfrom
Open
Additional models, for additional Palo Alto models#3813athompson-merlin wants to merge 5 commits intoytti:masterfrom
athompson-merlin wants to merge 5 commits intoytti:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
Not a dev, so no idea what rubocop or rake are. (Obviously I can guess, but never seen them before.) Learning one iota more about Ruby than I need to is wildly out of scope for me, but I still wanted to upstream these models if possible.
rubocop --auto-correct)rake test)Description
These three new models address two use cases the original Palo Alto models did not, (1) obtaining an XML output without needing to use the API, and (2) obtaining output in two different formats from the Panorama management server, which has slightly different syntax. The "XML" format can be used (with some work) to restore a firewall, but is largely un-parseable; the "set" format is more useful for every other scenario as it's parseable and pasteable.