Save input debugging to YAML simulation file#3810
Open
robertcheramy wants to merge 1 commit intomasterfrom
Open
Save input debugging to YAML simulation file#3810robertcheramy wants to merge 1 commit intomasterfrom
robertcheramy wants to merge 1 commit intomasterfrom
Conversation
- rewrite debug logging - remove unused logging - fix linuxgeneric
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
This PR introduces the possibility to save the input debug data directly in a YAML Simulation file, so that it will be easier for our users to provide one in model issues.
It rewrites the input debug logging, and removes logging where it wasn't used (dead code). As I did my tests on the linuxgeneric model, I fixed the problems I encountered there.