Add secret detection support for SNMP traps

[nicolasberens]

Pre-Request Checklist

• Passes rubocop code analysis (try rubocop --auto-correct)
• Tests added or adapted (try rake test)
• Changes are reflected in the documentation
• User-visible changes appended to CHANGELOG.md

Description

Closes Issue #3793

This Change adds support to detect SNMP community strings in the Vyos config.

It also extends the tests so this regression will get caught in the future.

[ytti]

Can you update changelog also please.

Additionally, if you wish, you can add unit test for the secret, so that there won't be regression.

[nicolasberens]

Updated Changelog.

I added the tests in the first commit.

[ytti]

What I meant, is testing for feature you added:
https://github.com/ytti/oxidized/blob/master/docs/ModelUnitTests.md#secrets

This is not mandatory, just if you want to ensure no regression.

[nicolasberens]

Oh, maybe i am understanding this wrong.

I thought that this is already covered by: https://github.com/ytti/oxidized/blob/master/spec/model/data/vyos%23Supermicro_1.4.3%23secret.yaml#L2 since it uses the same "secret"

[ytti]

Yes, I think you are right. Less precision in our testing, but should stop regression.