Add RBAC integration spec: user + group creation, ACL membership - #39
Merged
Conversation
… a role Covers a feature area with zero prior coverage (users/groups/ACLEdit) and exercises the exact code path behind the known Permission IntFlag schema mismatch (services/rbac.ts, services/users.ts): creates a user and a group through the admin UI, grants the user a Writer role on the group via ACLEdit, and confirms it both in the UI and via a direct API check of the persisted ACL edge's role value. Also documents three new gotchas hit along the way (README): getByLabel fuzzy-matching a field's own append-icon aria-label, a v-combobox/ v-select's dropdown menu teleporting outside its logical container same as a nested dialog's content, and a multi-select combobox's dropdown not auto-closing after picking an option. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011tXLywVq32tGPE7jCrdZVJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACLEdit. Creates a user and a group through the admin UI (/system/users,/system/groups), grants the user a Writer role on the group via ACLEdit's identity-select + role-select + "Update memberships" flow, and confirms it both in the UI and via a direct API check of the persisted ACL edge.PermissionIntFlag schema mismatch (services/rbac.ts/services/users.tswiden the generated1 | 2 | 4type back tonumberto send composite role values like 3/7) -- the spec asserts the persisted role is exactly3(Writer), so a regression there would be caught.getByLabel(X)can fuzzy-match a field's own append-icon aria-label ("X appended action") as well as the field itselfv-combobox/v-selectdropdown teleports outside its logical DOM container, same as the nested-dialog gotcha already documented -- queryrole="option"unscopedTest plan
npx tsc --noEmiton the playwright package -- clean