chore(loc): exclude fuzz and guest programs from LOC count#616
Conversation
Codex Code ReviewNo issues found in the PR diff. The changes only add the MIT Tests not run; this was a diff-only review. |
Review: chore(loc): exclude fuzz and guest programs from LOC countOverall: LGTM with one observation. Observation — dual semantics of
|
The loc tool counted executor/programs (RISC-V guest test programs) as production code. Add *fuzz*, *programs* and *program_artifacts* to the EXCLUDED patterns. This removes 502 LOC of guest test programs (executor/programs/rust/*, 30 files) from the reported total (32,937 -> 32,435). Fuzz harnesses already scored 0 because fuzz_targets/ coincidentally matched *target*; they are now excluded explicitly so a harness placed elsewhere under crypto/math/fuzz/ is not counted either.
5d634f3 to
1399d3c
Compare
Codex Code ReviewNo issues found in the PR diff. The change only adds LOC-report exclusions for fuzz harnesses, guest programs, and program artifacts. I don’t see security, correctness, or significant performance concerns from these added patterns. Tests were not run; review was based on the diff and matching repo paths. |
Review: chore(loc): exclude fuzz and guest programs from LOC countThe change is correct and consistent with the existing exclusion convention in this file. One thing worth noting: Low — The pattern If there's ever a production crate whose path includes "programs", it'll be dropped from the LOC count with no warning. A narrower path like Low — No directory matching this pattern exists in the repo today. Harmless as a forward-looking exclusion, but worth noting it's speculative. Otherwise no issues — no security, performance, or correctness concerns. |
The loc tool counted executor/programs (RISC-V guest test programs) as production code. Add fuzz, programs and program_artifacts to the EXCLUDED patterns.
This removes 502 LOC of guest test programs (executor/programs/rust/*, 30 files) from the reported total (32,937 -> 32,435). Fuzz harnesses already scored 0 because fuzz_targets/ coincidentally matched target; they are now excluded explicitly so a harness placed elsewhere under crypto/math/fuzz/ is not counted either.