Skip to content

fixed auction issue #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lironfara merged 2 commits into from
Jul 1, 2025
Merged

fixed auction issue #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63f7dd4
fixed auction issue
yuvalm008 Jul 1, 2025
7dfe527
fixed auction test
yuvalm008 Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .../com/TradingSystem/TradingSystem/ApplicationLayer/restControllers/UserRestController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1912,7 +1912,6 @@ public ResponseEntity<Object> placeAuctionBid(
return ResponseEntity.status(HttpStatus.UNAUTHORIZED)
.body("You are suspended and cannot place a bid");
}
member.addPurchaseToWishlist(storeService.getAuctionByProductId(storeId, productId)); // productId ->
// purchase
String previousBidder = storeService.placeBidForAuction(storeId, productId, member.getEmail(), bidAmount);
if (previousBidder != null) {
Expand All @@ -1928,6 +1927,10 @@ public ResponseEntity<Object> placeAuctionBid(
String.format("You have been outbid. New highest bid is %.2f", bidAmount), storeId);
log.info("Previous bidder {} notified of new bid", previousBidder);
}
else{
member.addPurchaseToWishlist(storeService.getAuctionByProductId(storeId, productId)); // productId ->

}

return ResponseEntity.ok("Bid placed successfully");
} catch (Exception e) {
Expand Down
2 changes: 1 addition & 1 deletion ...tem/src/test/java/com/TradingSystem/TradingSystem/BlackBoxTests/AuctionBlackBoxTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ void GivenInvalidProductId_WhenPlacingAuctionBid_ThenBidFails() throws Exception
.param("productId", "nonexistent-product")
.param("bidAmount", "120.0"))
.andExpect(status().isInternalServerError())
.andExpect(content().string(containsString("Auction not found here")));
.andExpect(content().string(containsString("Auction does not exist")));
}

// @Test
Expand Down