Fix cropZoneByPolygon to return separate zones #911
Open
AvetosDesign wants to merge 1 commit into
Open
Conversation
…sections When a zone's outline extends outside the board boundary and the intersection of that zone with the board polygon produces multiple disconnected pieces (MultiPolygon), the previous code packed all pieces into a single zone's SHAPE_POLY_SET via multiple AddOutline calls. This caused problems downstream: a multi-outline zone has one centroid (potentially outside any individual piece), KiCad's zone fill engine does not reliably handle multi-outline zones, and collectZones' bounding-box centroid filter could silently drop pieces whose centroids fell outside the expected area. The function's own docstring already stated "If the zone is split into multiple zones, return all of them" but the return type was None and no zones were ever returned. Fix: when the intersection is a MultiPolygon, return one Duplicate() of the input zone per piece, each with a single outline. The single-polygon case continues to modify the zone in place and return [zone]. The one call site in appendBoard is updated to iterate the returned list. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a zone's outline extends outside the board boundary and the intersection of that zone with the board polygon produces multiple disconnected pieces (MultiPolygon), the previous code packed all pieces into a single zone's SHAPE_POLY_SET via multiple AddOutline calls.
This caused problems downstream: a multi-outline zone has one centroid (potentially outside any individual piece), KiCad's zone fill engine does not reliably handle multi-outline zones, and collectZones' bounding-box centroid filter could silently drop pieces whose centroids fell outside the expected area.
The function's own docstring already stated "If the zone is split into multiple zones, return all of them" but the return type was None and no zones were ever returned.
Fix: when the intersection is a MultiPolygon, return one Duplicate() of the input zone per piece, each with a single outline. The single-polygon case continues to modify the zone in place and return [zone]. The one call site in appendBoard is updated to iterate the returned list.