Skip to content

registry.py: migrate deprecated pkg_resources#145

Open
hseg wants to merge 1 commit into
xlcnd:devfrom
hseg:patch-1
Open

registry.py: migrate deprecated pkg_resources#145
hseg wants to merge 1 commit into
xlcnd:devfrom
hseg:patch-1

Conversation

@hseg
Copy link
Copy Markdown

@hseg hseg commented Oct 29, 2024

As noted in https://setuptools.pypa.io/en/latest/pkg_resources.html, pkg_resources is deprecated. We were only using it for iter_entry_points anyway, which has been moved to importlib.metadata:entry_points

Changes proposed in this pull request:

  • Replace pkg_resources:iter_entry_points by importlib.metadata:entry_points

@xlcnd

As noted in https://setuptools.pypa.io/en/latest/pkg_resources.html,
pkg_resources is deprecated. We were only using it for iter_entry_points anyway,
which has been moved to importlib.metadata:entry_points
@hseg hseg requested a review from xlcnd as a code owner October 29, 2024 14:04
@KenjiTakahashi
Copy link
Copy Markdown

FYI: Since 3.12, pkg_resources is no longer part of stdlib and setuptools are not a part of the standard Python distribution either. Means that to be able to use isbnlib one needs to pip install setuptools first.

@pierreay
Copy link
Copy Markdown

Hello. Two years without any commit. Is isbnlib still maintained?

@rerowep
Copy link
Copy Markdown

rerowep commented Oct 8, 2025

Could you please merge this PR?

@hans-fritz-pommes
Copy link
Copy Markdown

hans-fritz-pommes commented Nov 6, 2025

Did you see the time of the last contribution of xlcnd and their profile?
I fear they fell in Putin - Ukraine war...

hans-fritz-pommes added a commit to hans-fritz-pommes/isbnlib that referenced this pull request Jan 22, 2026
@hans-fritz-pommes
Copy link
Copy Markdown

I have created a fork and am now trying to maintain it.
https://github.com/hans-fritz-pommes/isbnlib
You can install it with pip install isbnlib2.
Maybe remove isbnlib before.
The module name is the same - your code will run the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants