Enhance Bootloader with optional 'set prefix='#185
Open
ydirson wants to merge 1 commit intoxenserver:masterfrom
Open
Enhance Bootloader with optional 'set prefix='#185ydirson wants to merge 1 commit intoxenserver:masterfrom
ydirson wants to merge 1 commit intoxenserver:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
========================================
- Coverage 83.6% 83.6% -0.1%
========================================
Files 23 23
Lines 3368 3372 +4
========================================
+ Hits 2817 2819 +2
- Misses 551 553 +2
|
In distros like Almalinux 10, GRUB modules are installed in /usr/lib/grub in the rootfs. For GRUB to find them, a proper prefix has to be set, which we can identify using its UUID. This patch adds a new optional attribute to `Bootloader` object for this, which is a `dict` with two keys: - `uuid`: the UUID of the rootfs - `path`: the directory in the rootfs where modules will be searched for This is meant to be usable by host-installer in relevant contexts. Signed-off-by: Yann Dirson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In distros like Almalinux 10, GRUB modules are installed in /usr/lib/grub in the rootfs. For GRUB to find them, a proper prefix has to be set, which we can identify using its UUID.
This patch adds a new optional attribute to
Bootloaderobject for this, which is adictwith two keys:uuid: the UUID of the rootfspath: the directory in the rootfs where modules will be searched forThis is meant to be usable by host-installer in relevant contexts.