Skip to content

Conversation

@bernhardkaindl
Copy link

No description provided.

@bernhardkaindl bernhardkaindl requested a review from Copilot August 27, 2025 14:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes obsolete Python 2.7 test environments and configuration from the tox setup. The changes update the minimum tox version requirement and clean up all Python 2.7 related dependencies, test environments, and documentation references.

  • Removes all Python 2.7 specific test environments and dependencies
  • Updates minimum tox version to 4.6 and simplifies development setup
  • Cleans up obsolete coverage combination functionality that was specific to Python 2.7

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
tox.ini Removes py27 environments, covcombine section, and updates configuration for modern tox
pyproject.toml Adds test dependencies to coverage, mypy, and pytype extras
README.md Removes Python 2.7 support references and simplifies CI description
CONTRIBUTING.md Removes Python 2.7 development setup instructions and simplifies tox installation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +58 to +63
"python-libs[test]",
"coverage[toml]",
"diff_cover"
]
mypy = [
"python-libs[test]",
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding 'python-libs[test]' as a dependency to the coverage extra creates a circular dependency since this is the same package being defined in this pyproject.toml file. This should be removed or the test dependencies should be listed explicitly.

Suggested change
"python-libs[test]",
"coverage[toml]",
"diff_cover"
]
mypy = [
"python-libs[test]",
"mock",
"pyfakefs",
"pytest>=7",
"pytest-cov",
"pytest-forked",
"pytest_httpserver",
"pytest-localftpserver",
"pytest-subprocess",
"pytest-timeout",
"typing_extensions",
"coverage[toml]",
"diff_cover"
]
mypy = [
"mock",
"pyfakefs",
"pytest>=7",
"pytest-cov",
"pytest-forked",
"pytest_httpserver",
"pytest-localftpserver",
"pytest-subprocess",
"pytest-timeout",
"typing_extensions",

Copilot uses AI. Check for mistakes.
"diff_cover"
]
mypy = [
"python-libs[test]",
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding 'python-libs[test]' as a dependency to the mypy extra creates a circular dependency since this is the same package being defined in this pyproject.toml file. This should be removed or the test dependencies should be listed explicitly.

Copilot uses AI. Check for mistakes.
"types-toml",
]
pytype = [
"python-libs[test]",
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding 'python-libs[test]' as a dependency to the pytype extra creates a circular dependency since this is the same package being defined in this pyproject.toml file. This should be removed or the test dependencies should be listed explicitly.

Suggested change
"python-libs[test]",
"mock",
"pyfakefs",
"pytest>=7",
"pytest-cov",
"pytest-forked",
"pytest_httpserver",
"pytest-localftpserver",
"pytest-subprocess",
"pytest-timeout",
"typing_extensions",

Copilot uses AI. Check for mistakes.
CONTRIBUTING.md Outdated
systemctl enable --now --user podman.socket # Only configures the podman socket
systemctl start --user podman.socket # Start the docker-compatible unix socket
# Ubuntu only, Fedora 37 configures it already with more unqualifies search registries:
# Ubuntu only, Fedora configures unqualified search registries out-of-the box:
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a spelling error in 'out-of-the box' - it should be 'out-of-the-box' with hyphens.

Suggested change
# Ubuntu only, Fedora configures unqualified search registries out-of-the box:
# Ubuntu only, Fedora configures unqualified search registries out-of-the-box:

Copilot uses AI. Check for mistakes.
@coveralls
Copy link

coveralls commented Aug 27, 2025

Coverage Status

coverage: 83.358%. remained the same
when pulling 3590b8a on bernhard-xapi:tox-ini-cleanup-obsolete-py27-test-environments
into e1ce4cc on xenserver-next:master.

@bernhardkaindl bernhardkaindl force-pushed the tox-ini-cleanup-obsolete-py27-test-environments branch from 0400cc5 to 3590b8a Compare August 27, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants